xuefuz commented on a change in pull request #8785: [FLINK-11480][hive] Create
HiveTableFactory that creates TableSource/…
URL: https://github.com/apache/flink/pull/8785#discussion_r296045736
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/factories/TableFactoryUtil.java
##########
@@ -47,15 +48,14 @@ public static ExternalCatalog
findAndCreateExternalCatalog(Descriptor descriptor
*/
public static <T> TableSource<T> findAndCreateTableSource(Descriptor
descriptor) {
Map<String, String> properties = descriptor.toProperties();
-
Review comment:
I guess it's okay. It's more consistent with findAndCreateTableSink().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
