xuefuz commented on a change in pull request #8785: [FLINK-11480][hive] Create
HiveTableFactory that creates TableSource/…
URL: https://github.com/apache/flink/pull/8785#discussion_r296042944
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/factories/TableFactoryUtil.java
##########
@@ -83,4 +86,19 @@ public static ExternalCatalog
findAndCreateExternalCatalog(Descriptor descriptor
return tableSink;
}
+
+ /**
+ * Returns a table sink matching the descriptor.
+ */
+ public static <T> TableSink<T> findAndCreateTableSink(CatalogTable
table) {
Review comment:
Well, there is just one option. In that case, we need to make the other two
util methods public, which doesn't see good. I'd think the way here is cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
