zentol commented on a change in pull request #8646: [FLINK-12735][network] Make 
shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r297572793
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionTest.java
 ##########
 @@ -99,8 +93,8 @@ ResultSubpartition createFailingWritesSubpartition() throws 
Exception {
 
        // 
------------------------------------------------------------------------
 
-       static Path tmpPath() throws IOException {
-               return new File(TMP_DIR.newFolder(), "subpartition").toPath();
+       static Path tmpPath() {
+               return 
fileChannelManager.createChannel().getPathFile().toPath();
 
 Review comment:
   This commit is strictly speaking not necessary, correct? If so, I'd like to 
exclude it to prevent merge conflict with #8880.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to