zentol commented on a change in pull request #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager URL: https://github.com/apache/flink/pull/8646#discussion_r297632721
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/operators/sort/ExternalSortLargeRecordsITCase.java ########## @@ -71,7 +71,7 @@ public void beforeTest() { } @After - public void afterTest() { + public void afterTest() throws Exception { this.ioManager.close(); if (!this.ioManager.isProperlyShutDown()) { Review comment: most of the test were failing anyway if the ioManager shutdown failed due to subsequent assertions on `isProperlyShutdown`; thus b) is no longer a new problem. I would suggest to go through all tests, remove the `isProperlyShutDown` call if the test follows the same pattern, and potentially remove the method altogether if it is unused at that point. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services