zentol commented on a change in pull request #8646: [FLINK-12735][network] Make
shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r297631701
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionTest.java
##########
@@ -99,8 +93,8 @@ ResultSubpartition createFailingWritesSubpartition() throws
Exception {
//
------------------------------------------------------------------------
- static Path tmpPath() throws IOException {
- return new File(TMP_DIR.newFolder(), "subpartition").toPath();
+ static Path tmpPath() {
+ return
fileChannelManager.createChannel().getPathFile().toPath();
Review comment:
It is true that there are likely other merge conflicts too, but I disagree
with your implied conclusion that this means we don't have to worry about them.
More merge conflicts => more time spent on fixing them.
I'm not saying that we shouldn't make this change overall, but let's do it
at a later date, when merging it doesn't interfere with other people's critical
(release blocking!) work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
