sunhaibotb commented on a change in pull request #8811: [FLINK-12777][network]
Support CheckpointBarrierHandler in StreamTwoInputSelectableProcessor
URL: https://github.com/apache/flink/pull/8811#discussion_r297529503
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CachedBufferStorage.java
##########
@@ -82,29 +92,30 @@ public BufferOrEventSequence
rollOverWithoutReusingResources() {
}
@Override
- public void close() {
+ public void close() throws IOException {
BufferOrEvent boe;
while ((boe = currentBuffers.poll()) != null) {
if (boe.isBuffer()) {
boe.getBuffer().recycleBuffer();
}
}
+ super.close();
}
@Override
- public long getBytesBlocked() {
+ public long getPendingBytes() {
return bytesBlocked;
}
//
------------------------------------------------------------------------
/**
* This class represents a sequence of cached buffers and events,
created by the
- * {@link CachedBufferBlocker}.
+ * {@link CachedBufferStorage}.
*/
public static class CachedBufferOrEventSequence implements
BufferOrEventSequence {
- /** The sequence of buffers and events to be consumed by {@link
BarrierBuffer}.*/
+ /** The sequence of buffers and events to be consumed by {@link
CheckpointedInputGate}.*/
Review comment:
Nit: for a private member, we should not specify who
(`CheckpointedInputGate`) will consume it, which will be highly coupled, and I
think it would be better to use more abstract expression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
