sunhaibotb commented on a change in pull request #8811: [FLINK-12777][network]
Support CheckpointBarrierHandler in StreamTwoInputSelectableProcessor
URL: https://github.com/apache/flink/pull/8811#discussion_r297551083
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CachedBufferStorage.java
##########
@@ -43,14 +47,20 @@
/** The current memory queue for caching the buffers or events. */
private ArrayDeque<BufferOrEvent> currentBuffers;
+ @VisibleForTesting
+ CachedBufferStorage(int pageSize) {
Review comment:
I don't think this constructor is needed. My understanding is that the
`@VisibleForTesting` constructor should be added in following case: the public
constructor don't want to expose certain parameters, while these parameters
need to be able to set during testing. It should be different here, just to
pass fewer parameters during the test, which makes that the production code
look like to mix some test content, especially seen the "Testing" string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
