sunhaibotb commented on a change in pull request #8811: [FLINK-12777][network]
Support CheckpointBarrierHandler in StreamTwoInputSelectableProcessor
URL: https://github.com/apache/flink/pull/8811#discussion_r297573746
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/BufferStorageTestBase.java
##########
@@ -30,29 +30,32 @@
import java.io.IOException;
import java.util.ArrayDeque;
import java.util.ArrayList;
+import java.util.Optional;
import java.util.Random;
import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
/**
- * Tests for {@link BufferBlocker}.
+ * Tests for {@link BufferStorage}.
*/
-public abstract class BufferBlockerTestBase {
+public abstract class BufferStorageTestBase {
protected static final int PAGE_SIZE = 4096;
- abstract BufferBlocker createBufferBlocker();
+ abstract BufferStorage createBufferBlocker();
Review comment:
Nit: The method name should also be changed accordingly to
`createBufferStorage`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
