bowenli86 commented on a change in pull request #8890: [FLINK-12989][hive]:
Generate HiveTableSink from from a Hive table
URL: https://github.com/apache/flink/pull/8890#discussion_r297786954
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectPath.java
##########
@@ -28,8 +31,19 @@
* A database name and object (table/view/function) name combo in a catalog.
*/
public class ObjectPath {
- private final String databaseName;
- private final String objectName;
+ // Default database name
+ private static final String DEFAULT_DB_NAME = "default";
+ // Default object name
+ private static final String DEFAULT_OBJECT_NAME = "default";
+
+ private String databaseName = DEFAULT_DB_NAME;
+ private String objectName = DEFAULT_OBJECT_NAME;
+
+ /**
+ * Default constructor used for serialization/de-serialization.
+ */
+ public ObjectPath() {
Review comment:
I feel the changes of ObjectPath are somewhat more like a hack, and I'm not
sure if we should expose this constructor to public.
Is there any way to not touch ObjectPath but do some changes to ser/de logic
itself?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
