bowenli86 commented on a change in pull request #8890: [FLINK-12989][hive]:
Generate HiveTableSink from from a Hive table
URL: https://github.com/apache/flink/pull/8890#discussion_r297883585
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableOutputFormat.java
##########
@@ -139,23 +141,20 @@
// to convert Flink object to Hive object
private transient HiveObjectConversion[] hiveConversions;
- public HiveTableOutputFormat(JobConf jobConf, String databaseName,
String tableName, List<String> partitionColumns,
- RowTypeInfo
rowTypeInfo, HiveTablePartition hiveTablePartition,
- Properties
tableProperties, boolean overwrite) {
+ public HiveTableOutputFormat(JobConf jobConf, ObjectPath tablePath,
CatalogTableImpl table, HiveTablePartition hiveTablePartition,
Review comment:
probably just need `CatalogTable` rather than `CatalogTableImpl`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
