bowenli86 commented on a change in pull request #8890: [FLINK-12989][hive]:
Generate HiveTableSink from from a Hive table
URL: https://github.com/apache/flink/pull/8890#discussion_r297884135
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/batch/connectors/hive/HiveTableOutputFormatTest.java
##########
@@ -157,15 +158,14 @@ private CatalogTable createCatalogTable(TableSchema
tableSchema, int numPartCols
return new CatalogTableImpl(tableSchema,
Arrays.asList(partCols), new HashMap<>(), "");
}
- private HiveTableOutputFormat createHiveTableOutputFormat(ObjectPath
tablePath, Table hiveTable,
- RowTypeInfo rowTypeInfo, Map<String, Object> partSpec,
boolean overwrite) throws Exception {
+ private HiveTableOutputFormat createHiveTableOutputFormat(ObjectPath
tablePath, CatalogTableImpl catalogTable, Table hiveTable,
Review comment:
probably just need CatalogTable rather than CatalogTableImpl?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
