StephanEwen commented on issue #8740: [FLINK-12763][runtime] Fail job 
immediately if tasks’ resource needs can not be satisfied.
URL: https://github.com/apache/flink/pull/8740#issuecomment-508452576
 
 
   Could you add a description about what is changes here? There seems to be a 
lot going on, like a
     - a new "registration period" for taskmanager
     - different matching between resource specs
     - resource specs are only applicable if they registered within a certain 
time
     - etc.
   
   As described also in the [code contribution and style 
guide](https://docs.google.com/document/d/1owKfK1DwXA-w6qnx3R7t2D_o0BsFkkukGlRhvl3XXjQ),
 this is really important for a proper review. Otherwise one cannot review the 
mechanism well, which is even more important than the actual implementation in 
code.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to