beyond1920 commented on a change in pull request #9006:
[FLINK-13107][table-planner-blink] Copy TableApi IT and UT to Blink planner
URL: https://github.com/apache/flink/pull/9006#discussion_r300833841
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/schema/TypedFlinkTableFunction.scala
##########
@@ -46,8 +47,18 @@ class TypedFlinkTableFunction(
typeFactory: RelDataTypeFactory,
arguments: Array[AnyRef],
argTypes: Array[Class[_]]): RelDataType = {
- // we have determined the row type before, just convert it to RelDataType
- typeFactory.asInstanceOf[FlinkTypeFactory].createFieldTypeFromLogicalType(
- fromDataTypeToLogicalType(externalResultType))
+ val fieldTypes = TableEnvironment.getFieldTypes(externalResultType)
Review comment:
OK, I would use FieldInfoUtils in api-module instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
