beyond1920 commented on a change in pull request #9006:
[FLINK-13107][table-planner-blink] Copy TableApi IT and UT to Blink planner
URL: https://github.com/apache/flink/pull/9006#discussion_r300904797
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/expressions/aggregations.scala
##########
@@ -57,7 +58,10 @@ case class Sum(child: PlannerExpression) extends
Aggregation {
override private[flink] def children: Seq[PlannerExpression] = Seq(child)
override def toString = s"sum($child)"
- override private[flink] def resultType = child.resultType
+ override private[flink] def resultType = {
Review comment:
Run a sql query using blink, the behavior already using behavior of blink.
It would be strange if the behavior is different when run a tableApi query.
So I think we should use behavior of blink.
Do you mean change the commit message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
