beyond1920 commented on a change in pull request #9006:
[FLINK-13107][table-planner-blink] Copy TableApi IT and UT to Blink planner
URL: https://github.com/apache/flink/pull/9006#discussion_r300904727
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/util/SetOpRewriteUtil.scala
##########
@@ -81,7 +81,7 @@ object SetOpRewriteUtil {
val fieldTypes =
logicalType.getChildren.map(fromLogicalTypeToTypeInfo).toArray
val tf = new ReplicateRows(fieldTypes)
val resultType = fromLegacyInfoToDataType(new RowTypeInfo(fieldTypes,
fieldNames))
- val function = new TypedFlinkTableFunction(tf, resultType)
+ val function = new TypedFlinkTableFunction(tf, fieldNames, resultType)
Review comment:
Good catch. However `SetOpRewriteUtil` is a new class, which I found compile
error after rebase code, so The update not in first commit...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
