wuchong commented on a change in pull request #9045: [FLINK-12955][hbase] Support LookupableTableSource for HBase URL: https://github.com/apache/flink/pull/9045#discussion_r301631642
########## File path: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseValidator.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.addons.hbase; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.descriptors.ConnectorDescriptorValidator; +import org.apache.flink.table.descriptors.DescriptorProperties; + +import java.util.Arrays; +import java.util.List; + +/** + * The validator for HBase. + * More features to be supported, e.g., batch read/write, async api(support from hbase version 2.0.0), Caching for LookupFunction. + */ +@Internal +public class HBaseValidator extends ConnectorDescriptorValidator { + + public static final String CONNECTOR_TYPE_VALUE_HBASE = "hbase"; Review comment: I just know all the existing connector validators (e.g. KafkaValidator, CsvValidator) are all placed in `org.apache.flink.table.descriptors` package. This is not mandatory, but is suggested to do. So I will move this file to `org.apache.flink.table.descriptors`, and then the static field have to be public. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
