wuchong commented on a change in pull request #9045: [FLINK-12955][hbase]
Support LookupableTableSource for HBase
URL: https://github.com/apache/flink/pull/9045#discussion_r301635846
##########
File path:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseRowInputFormat.java
##########
@@ -53,78 +47,33 @@
private static final long serialVersionUID = 1L;
private static final Logger LOG =
LoggerFactory.getLogger(HBaseRowInputFormat.class);
- private String tableName;
- private transient org.apache.hadoop.conf.Configuration conf;
- private HBaseTableSchema schema;
- private transient Charset stringCharset;
- // family keys
- private byte[][] families;
- // qualifier keys
- private byte[][][] qualifiers;
- // qualifier types
- private int[][] types;
+ private final String tableName;
+ private final HBaseTableSchema schema;
- // row which is returned
- private Row resultRow;
- // nested family rows
- private Row[] familyRows;
+ private transient org.apache.hadoop.conf.Configuration conf;
+ private transient HBaseReadHelper readHelper;
public HBaseRowInputFormat(org.apache.hadoop.conf.Configuration conf,
String tableName, HBaseTableSchema schema) {
Review comment:
`HBaseRowInputFormat` is a public API to let users construct an
`InputFormat` for HBase. They can be used in DataStream or DataSet.
And it was public before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
