wuchong commented on a change in pull request #9045: [FLINK-12955][hbase] Support LookupableTableSource for HBase URL: https://github.com/apache/flink/pull/9045#discussion_r301637293
########## File path: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseLookupFunction.java ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.addons.hbase; + +import org.apache.flink.addons.hbase.util.HBaseConfigurationUtil; +import org.apache.flink.addons.hbase.util.HBaseReadHelper; +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.table.functions.FunctionContext; +import org.apache.flink.table.functions.TableFunction; +import org.apache.flink.types.Row; +import org.apache.flink.util.StringUtils; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseConfiguration; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.TableNotFoundException; +import org.apache.hadoop.hbase.client.Connection; +import org.apache.hadoop.hbase.client.ConnectionFactory; +import org.apache.hadoop.hbase.client.HTable; +import org.apache.hadoop.hbase.client.Result; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; + +/** + * The HBaseLookupFunction is a standard user-defined table function, it can be used in tableAPI + * and also useful for temporal table join plan in SQL. + */ +public class HBaseLookupFunction extends TableFunction<Row> { + private static final Logger LOG = LoggerFactory.getLogger(HBaseLookupFunction.class); + private static final long serialVersionUID = 1L; + + private final String hTableName; + private final byte[] serializedConfig; + private final HBaseTableSchema hbaseTableSchema; + + private transient HBaseReadHelper readHelper; + private transient Connection hConnection; + private transient HTable table; + + public HBaseLookupFunction( Review comment: This is intended. `HBaseLookupFunction` is a public API to let users construct it and use it in Table API directly via `env.registerFunction(TableFunction)`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
