twalthr commented on a change in pull request #9167: [FLINK-13279][table]
Fallback to the builtin catalog when looking for registered tables.
URL: https://github.com/apache/flink/pull/9167#discussion_r304929120
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/PlannerBase.scala
##########
@@ -83,7 +83,9 @@ abstract class PlannerBase(
config,
functionCatalog,
asRootSchema(new CatalogManagerCalciteSchema(catalogManager,
isStreamingMode)),
- getTraitDefs.toList
+ getTraitDefs.toList,
+ catalogManager.getBuiltinCatalogName,
+
catalogManager.getCatalog(catalogManager.getBuiltinCatalogName).get().getDefaultDatabase
Review comment:
nit: shall we just introduce a `getBuiltInDatabaseName` and remove these
chains here and at other locations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services