twalthr commented on a change in pull request #9167: [FLINK-13279][table]
Fallback to the builtin catalog when looking for registered tables.
URL: https://github.com/apache/flink/pull/9167#discussion_r304925078
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java
##########
@@ -128,7 +128,9 @@ public CatalogManager(String defaultCatalogName, Catalog
defaultCatalog) {
catalogs.put(defaultCatalogName, defaultCatalog);
this.currentCatalogName = defaultCatalogName;
this.currentDatabaseName = defaultCatalog.getDefaultDatabase();
- this.defaultCatalogName = defaultCatalogName;
+
+ // right now the default catalog is always the builtin one
+ this.builtinCatalogName = defaultCatalogName;
Review comment:
update parameter name to `builtInCatalogName` as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services