twalthr commented on a change in pull request #9167: [FLINK-13279][table]
Fallback to the builtin catalog when looking for registered tables.
URL: https://github.com/apache/flink/pull/9167#discussion_r304921386
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/EnvironmentSettings.java
##########
@@ -206,16 +208,30 @@ public Builder inStreamingMode() {
/**
* Specifies the name of the initial catalog to be created when
instantiating
- * a {@link TableEnvironment}. Default: "default_catalog".
+ * a {@link TableEnvironment}. This catalog will be used to
store all
+ * non-serializable objects such as tables and functions
registered via e.g.
+ * {@link TableEnvironment#registerTableSink(String,
TableSink)} or
+ * {@link TableEnvironment#registerFunction(String,
ScalarFunction)}. This will
+ * also be the initial value for the current catalog which can
be altered via
+ * {@link TableEnvironment#useCatalog(String)}.
+ *
+ * <p>Default: "default_catalog".
*/
public Builder withBuiltInCatalogName(String
builtInCatalogName) {
this.builtInCatalogName = builtInCatalogName;
return this;
}
/**
- * Specifies the name of the default database in the initial
catalog to be created when instantiating
- * a {@link TableEnvironment}. Default: "default_database".
+ * Specifies the name of the default database in the initial
catalog to be
+ * created when instantiating a {@link TableEnvironment}.This
database will be
+ * used to store all non-serializable objects such as tables
and functions registered
+ * via e.g. {@link TableEnvironment#registerTableSink(String,
TableSink)} or
+ * {@link TableEnvironment#registerFunction(String,
ScalarFunction)}. This will
Review comment:
nit: `This` => `It`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
