wuchong commented on a change in pull request #8966:
[FLINK-13074][table-planner-blink] Add PartitionableTableSink bridge logic to
flink&blink …
URL: https://github.com/apache/flink/pull/8966#discussion_r305325355
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/sinks/TableSinkUtils.scala
##########
@@ -62,5 +68,18 @@ object TableSinkUtils {
s"Query result schema: $srcSchema\n" +
s"TableSink schema: $sinkSchema")
}
+ // check partitions are valid
+ sink match {
Review comment:
Please check `partitionableTableSink.getPartitionFieldNames` is not empty
first if `sinkOperation.getStaticPartitions` is not empty. Regarding to the
javadoc, if `sink.getPartitionFieldNames` is empty, it is not a partitioned
sink.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
