wuchong commented on a change in pull request #8966:
[FLINK-13074][table-planner-blink] Add PartitionableTableSink bridge logic to
flink&blink …
URL: https://github.com/apache/flink/pull/8966#discussion_r305362416
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/sinks/TableSinkUtils.scala
##########
@@ -67,5 +71,19 @@ object TableSinkUtils {
s"Query result schema: $srcSchema\n" +
s"TableSink schema: $sinkSchema")
}
+ // check partitions are valid
+ sink match {
Review comment:
I don't think so. We can't guarantee sql parser is the only entry for insert
partition. Maybe we will support this on Table API in the future. And it
doesn't hurt anything to do a validation check when inserting.
Btw, where is the check when we generate the sql node?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
