wuchong commented on a change in pull request #8966:
[FLINK-13074][table-planner-blink] Add PartitionableTableSink bridge logic to
flink&blink …
URL: https://github.com/apache/flink/pull/8966#discussion_r305366175
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/PlannerBase.scala
##########
@@ -173,7 +165,12 @@ abstract class PlannerBase(
case catalogSink: CatalogSinkModifyOperation =>
val input =
getRelBuilder.queryOperation(modifyOperation.getChild).build()
getTableSink(catalogSink.getTablePath).map(sink => {
- TableSinkUtils.validateSink(catalogSink.getChild,
catalogSink.getTablePath, sink)
+ TableSinkUtils.validateSink(catalogSink, catalogSink.getTablePath,
sink)
+ sink match {
+ case partitionableSink: PartitionableTableSink =>
Review comment:
From user's point of view, if it is not a partitioned sink
(`getPartitionFieldNames()` returns empty), the `setStaticPartition` should
never be called. However, currently, `setStaticPartition` is always be called
(may pass in an empty partition map).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
