[
https://issues.apache.org/jira/browse/FLINK-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907937#comment-14907937
]
ASF GitHub Bot commented on FLINK-2561:
---------------------------------------
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1183
[FLINK-2561] Adda missing Gelly scala methods and tests
This PR *partially* address FLINK-2561.
- It adds all missing methods to Graph, except the recently added (#1149)
`fromCsvReader`. It is not straight-forward to port this one (e.g. with a
simple wrapper), so I suggest we address it with a separate JIRA.
- It ports all existing tests to use `collect` instead of files and adds
tests for the new methods.
- It adds a completeness test (where `fromCsvReader` is temporarily
excluded)
- It adds the Scala version of the GraphMetrics example. For more examples
to be added, #1033 and #1152 should be merged.
I will submit a separate PR for the documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vasia/flink gelly-scala
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1183
----
commit c446c0ca648c9a22e241931a3ea08104e41339a8
Author: vasia <[email protected]>
Date: 2015-09-24T20:08:10Z
[FLINK-2561] [gelly] add missing methods to Graph:
add-remove edges/vertices, difference, graph creation methods,
validate, getTriplets.
commit 3251d19c2d77192f2f0260c00eb88cf449e26ffa
Author: vasia <[email protected]>
Date: 2015-09-24T20:10:25Z
[FLINK-2561] [gelly] add missing utility mappers
commit 1fb32d5dcf91611133266bcf48ae083da0c7ae44
Author: vasia <[email protected]>
Date: 2015-09-24T21:31:38Z
[FLINK-2561] [gelly] convert existing tests to use collect instead of files;
add tests for newly added operations
commit 0ce15f4795d174f5d7306453f94632c045ee622e
Author: vasia <[email protected]>
Date: 2015-09-24T22:39:04Z
[FLINK-2561] [gelly] add completeness test: fromCsvReader method is missing;
fix checkstyle violations
commit 510d9cd38f1eead6b346dc595b169cffc8e3ac67
Author: vasia <[email protected]>
Date: 2015-09-25T09:20:15Z
[FLINK-2561] [gelly] add GraphMetrics Scala example
----
> Sync Gelly Java and Scala APIs
> ------------------------------
>
> Key: FLINK-2561
> URL: https://issues.apache.org/jira/browse/FLINK-2561
> Project: Flink
> Issue Type: Task
> Components: Gelly
> Reporter: Vasia Kalavri
> Assignee: Vasia Kalavri
>
> There is some functionality and tests missing from the Gelly Scala API. This
> should be added, together with documentation, a completeness test and some
> usage examples.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
