[
https://issues.apache.org/jira/browse/FLINK-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933167#comment-14933167
]
ASF GitHub Bot commented on FLINK-2561:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1183#issuecomment-143714240
Looks good to me!
One style comment: I think that `collect()` should be written with
parenthesis. In Scala, you use parenthesis if the methods are not purely
accessing properties. The `collect()` function as effects.
Minor comment about the `serialVersionUID` in Scala inline.
> Sync Gelly Java and Scala APIs
> ------------------------------
>
> Key: FLINK-2561
> URL: https://issues.apache.org/jira/browse/FLINK-2561
> Project: Flink
> Issue Type: Task
> Components: Gelly
> Reporter: Vasia Kalavri
> Assignee: Vasia Kalavri
>
> There is some functionality and tests missing from the Gelly Scala API. This
> should be added, together with documentation, a completeness test and some
> usage examples.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
