zentol commented on a change in pull request #9250: [FLINK-13371][coordination]
Prevent leaks of blocking partitions
URL: https://github.com/apache/flink/pull/9250#discussion_r309106829
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1066,6 +1066,8 @@ void markFinished(Map<String, Accumulator<?, ?>>
userAccumulators, IOMetrics met
else if (current == CANCELING) {
// we sent a cancel call, and the task manager
finished before it arrived. We
// will never get a CANCELED call back from the
job manager
+ // release all partitions because partitions
should only be kept if the execution reaches FINISHED
+
sendReleaseIntermediateResultPartitionsRpcCall();
Review comment:
This code here only handles the state reconciliation in the case that an
execution is finished while we're canceling.
If we go from RUNNING->CANCELING->CANCELED then the TM cleans up partitions.
If an execution fails it is also cleaned up on the TM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
