zentol commented on a change in pull request #9250: [FLINK-13371][coordination]
Prevent leaks of blocking partitions
URL: https://github.com/apache/flink/pull/9250#discussion_r309597163
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
##########
@@ -721,4 +853,35 @@ public void returnLogicalSlot(LogicalSlot logicalSlot) {
returnedSlot.complete(logicalSlot);
}
}
+
+ public static class TestingShuffleMaster implements
ShuffleMaster<ShuffleDescriptor> {
Review comment:
we could, but I don`t see much value. The only overlap is the queue for
release partitions which is rather trivial. In fact for the ExecutionTest
should probably store the ShuffleDescriptor and not just the ResultPartitionID.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
