zentol commented on a change in pull request #9250: [FLINK-13371][coordination]
Prevent leaks of blocking partitions
URL: https://github.com/apache/flink/pull/9250#discussion_r309600284
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
##########
@@ -527,12 +535,174 @@ public void testEagerSchedulingFailureReturnsSlot()
throws Exception {
}
@Test
- public void testPartitionRetainedWhenFinished() throws Exception {
+ public void testPartitionReleaseOnFinishWhileCanceling() throws
Exception {
Review comment:
there are quite a few differences by now as to how the TE gateway is set up,
what kind of tracker is used and how the job is constructed. Could we force
deduplication? yes, but I don't think we'd make the test any more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
