GJL commented on a change in pull request #9268: [FLINK-13452] Ensure to fail
global when exception happens during reseting tasks of regions
URL: https://github.com/apache/flink/pull/9268#discussion_r309723755
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/RegionFailoverITCase.java
##########
@@ -97,8 +111,10 @@
@Before
public void setup() throws Exception {
+ HighAvailabilityServicesUtilsTest.TestHAFactory.haServices =
new FailHaServices(new TestingCheckpointRecoveryFactory(new
FailRecoverCompletedCheckpointStore(1, 1), new
StandaloneCheckpointIDCounter()), TestingUtils.defaultExecutor());
Configuration configuration = new Configuration();
configuration.setString(JobManagerOptions.EXECUTION_FAILOVER_STRATEGY,
"region");
+ configuration.setString(HighAvailabilityOptions.HA_MODE,
HighAvailabilityServicesUtilsTest.TestHAFactory.class.getName());
Review comment:
Interesting feature, didn't know about it before. However, I have two
questions regarding this integration test:
1. As before, isn't it enough to use a
[RestartStrategy](https://github.com/apache/flink/blob/1dd64058985afd44cae6a5119c4843b2dd85873d/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyFactory.java#L136)
that returns an exceptionally completed future?
1. We already test that `failGlobal` is invoked from the unit tests. Does
the integration test add coverage?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
