GJL commented on a change in pull request #9268: [FLINK-13452] Ensure to fail
global when exception happens during reseting tasks of regions
URL: https://github.com/apache/flink/pull/9268#discussion_r309680359
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategy.java
##########
@@ -42,6 +44,7 @@
*
* @param restarter The hook to restart the ExecutionGraph
* @param executor An scheduled executor to delay the restart
+ * @return A {@link CompletableFuture} that will be completed when the
restarting process is done.
*/
- void restart(RestartCallback restarter, ScheduledExecutor executor);
+ CompletableFuture<?> restart(RestartCallback restarter,
ScheduledExecutor executor);
Review comment:
I think that `CompletableFuture<Void>` would convey clearly that *"nothing"*
is returned by the future.
Also, wildcards in return types should be avoided:
https://stackoverflow.com/a/22815270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
