GJL commented on a change in pull request #9268: [FLINK-13452] Ensure to fail
global when exception happens during reseting tasks of regions
URL: https://github.com/apache/flink/pull/9268#discussion_r310611585
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FixedDelayRestartStrategy.java
##########
@@ -60,9 +63,13 @@ public boolean canRestart() {
}
@Override
- public void restart(final RestartCallback restarter, ScheduledExecutor
executor) {
+ public CompletableFuture<Void> restart(final RestartCallback restarter,
ScheduledExecutor executor) {
currentRestartAttempt++;
- executor.schedule(restarter::triggerFullRecovery,
delayBetweenRestartAttempts, TimeUnit.MILLISECONDS);
+ Supplier<Void> restartSupplier = () -> {
Review comment:
This conversion to `Supplier` is duplicated multiple times. See my other
comment in `FutureUtils`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
