lincoln-lil commented on a change in pull request #9335: [FLINK-13503][API] Add
contract in `LookupableTableSource` to specify the behavior when lookupKeys
contains null.
URL: https://github.com/apache/flink/pull/9335#discussion_r310083053
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/LookupableTableSource.java
##########
@@ -33,13 +33,33 @@
public interface LookupableTableSource<T> extends TableSource<T> {
/**
- * Gets the {@link TableFunction} which supports lookup one key at a
time.
+ * Gets the {@link TableFunction} which supports lookup one key at a
time. Calling `eval`
+ * method in the returned {@link TableFunction} means send a lookup
request to the TableSource.
+ *
* @param lookupKeys the chosen field names as lookup keys, it is in
the defined order
+ *
+ * <p>IMPORTANT:
+ * Lookup key in a request may contain null value. When it happens, it
expects to lookup
Review comment:
key -> keys
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
