lincoln-lil commented on a change in pull request #9335: [FLINK-13503][API] Add
contract in `LookupableTableSource` to specify the behavior when lookupKeys
contains null.
URL: https://github.com/apache/flink/pull/9335#discussion_r310083252
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCLookupFunction.java
##########
@@ -198,13 +231,23 @@ public void close() throws IOException {
cache.cleanUp();
cache = null;
}
- if (statement != null) {
+ if (fastStatement != null) {
+ try {
+ fastStatement.close();
+ } catch (SQLException e) {
+ LOG.info("JDBC fastStatement could not be
closed: " + e.getMessage());
+ } finally {
+ fastStatement = null;
+ }
+ }
+
+ if (slowStatement != null) {
try {
- statement.close();
+ slowStatement.close();
} catch (SQLException e) {
- LOG.info("JDBC statement could not be closed: "
+ e.getMessage());
+ LOG.info("JDBC fastStatement could not be
closed: " + e.getMessage());
Review comment:
fast -> slow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
