lincoln-lil commented on a change in pull request #9335: [FLINK-13503][API] Add
contract in `LookupableTableSource` to specify the behavior when lookupKeys
contains null.
URL: https://github.com/apache/flink/pull/9335#discussion_r310083489
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCLookupFunction.java
##########
@@ -46,12 +46,22 @@
import static org.apache.flink.util.Preconditions.checkNotNull;
/**
- * A {@link TableFunction} to query fields from JDBC by keys.
- * The query template like:
+ * A {@link TableFunction} to fastQuery fields from JDBC by keys.
+ * If look up keys don't contain any null value, using the fastQuery template
like:
* <PRE>
* SELECT c, d, e, f from T where a = ? and b = ?
* </PRE>
*
+ * If lookup keys contain any null value, using the fastQuery template like:
Review comment:
fastQuery -> slowQuery
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
