wuchong commented on a change in pull request #9316:
[FLINK-13529][table-planner-blink] Verify and correct agg function's semantic
for Blink planner
URL: https://github.com/apache/flink/pull/9316#discussion_r310386622
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/AggFunctionFactory.scala
##########
@@ -610,19 +608,19 @@ class AggFunctionFactory(
argTypes: Array[LogicalType],
index: Int): UserDefinedFunction = {
if (needRetraction(index)) {
- new ConcatWithRetractAggFunction
+ new ListAggWithRetractAggFunction
} else {
- new ConcatAggFunction(1)
+ new ListAggFunction(1)
}
}
private def createConcatWsAggFunction(
Review comment:
Rename the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
