wuchong commented on a change in pull request #9316:
[FLINK-13529][table-planner-blink] Verify and correct agg function's semantic
for Blink planner
URL: https://github.com/apache/flink/pull/9316#discussion_r310386367
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/sql/SqlFirstLastValueAggFunction.java
##########
@@ -45,7 +44,7 @@ public SqlFirstLastValueAggFunction(SqlKind sqlKind) {
sqlKind,
ReturnTypes.ARG0_NULLABLE_IF_EMPTY,
null,
- OperandTypes.or(OperandTypes.ANY,
OperandTypes.family(SqlTypeFamily.ANY, SqlTypeFamily.ANY)),
+ OperandTypes.ANY,
Review comment:
Could you align the implementation with
`org.apache.calcite.sql.fun.SqlFirstLastValueAggFunction`? The only different
should be `requirsOver`, and would be great to mention it in the class javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
