wuchong commented on a change in pull request #9316:
[FLINK-13529][table-planner-blink] Verify and correct agg function's semantic
for Blink planner
URL: https://github.com/apache/flink/pull/9316#discussion_r310385134
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/agg/SortAggITCase.scala
##########
@@ -138,27 +138,27 @@ class SortAggITCase
}
// NOTE: Spark has agg functions collect_list(), collect_set().
- // instead, we'll test concat_agg() here
+ // instead, we'll test LISTAGG() here
@Ignore
@Test
def testConcatAgg(): Unit = {
checkResult(
- "SELECT concat_agg('-', c), concat_agg(c) FROM SmallTable3",
+ "SELECT LISTAGG(c, '-'), LISTAGG(c, '-') FROM SmallTable3",
Review comment:
The second is `LISTAGG(c)` ?
And can we open the test now ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
