lirui-apache commented on a change in pull request #9342: [FLINK-13438][hive]
Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors
URL: https://github.com/apache/flink/pull/9342#discussion_r311460022
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTypeUtil.java
##########
@@ -256,9 +258,9 @@ private static DataType
toFlinkPrimitiveType(PrimitiveTypeInfo hiveType) {
case DOUBLE:
return DataTypes.DOUBLE();
case DATE:
- return DataTypes.DATE();
+ return DataTypes.DATE().bridgedTo(Date.class);
case TIMESTAMP:
- return DataTypes.TIMESTAMP();
+ return
DataTypes.TIMESTAMP(3).bridgedTo(Timestamp.class);
Review comment:
If that's the case, please add some comments here to explain why the
precision has to be 3. Besides, does this mean we'll lose precision when
reading a timestamp from Hive into Flink?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
