lirui-apache commented on a change in pull request #9342: [FLINK-13438][hive]
Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors
URL: https://github.com/apache/flink/pull/9342#discussion_r312351627
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTypeUtil.java
##########
@@ -256,9 +258,9 @@ private static DataType
toFlinkPrimitiveType(PrimitiveTypeInfo hiveType) {
case DOUBLE:
return DataTypes.DOUBLE();
case DATE:
- return DataTypes.DATE();
+ return DataTypes.DATE().bridgedTo(Date.class);
case TIMESTAMP:
- return DataTypes.TIMESTAMP();
+ return
DataTypes.TIMESTAMP(3).bridgedTo(Timestamp.class);
Review comment:
I agree it's better to warn and document this limitation than totally ban
timestamp from Hive connector. And in the long run, shall we support timestamp
with higher precision in Flink? Since both `java.sql.Timestamp` and
`java.time.LocalDateTime` support up to precision 9, I don't see a good reason
why Flink has to limit precision to 3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
