dawidwys commented on a change in pull request #9382: [FLINK-13600][table]
Rework TableEnvironment.connect() class hierarchy
URL: https://github.com/apache/flink/pull/9382#discussion_r311905070
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/descriptors/StreamTableDescriptor.java
##########
@@ -21,92 +21,18 @@
import org.apache.flink.annotation.PublicEvolving;
import org.apache.flink.table.api.TableEnvironment;
-import java.util.Map;
-import java.util.Optional;
-
-import static
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE;
-import static
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE_VALUE_APPEND;
-import static
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE_VALUE_RETRACT;
-import static
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE_VALUE_UPSERT;
-
/**
- * Descriptor for specifying a table source and/or sink in a streaming
environment.
+ * Describes a table connected from a streaming environment.
*/
@PublicEvolving
-public class StreamTableDescriptor
- extends ConnectTableDescriptor<StreamTableDescriptor>
- implements StreamableDescriptor<StreamTableDescriptor> {
-
- private Optional<String> updateMode = Optional.empty();
+public final class StreamTableDescriptor extends ConnectTableDescriptor {
Review comment:
Probably we can't do it because of backwards compatibility, but I will put
it here anyway.
Do we even need the `StreamTableDescriptor`? It has no additional methods
compared to `ConnectTableDescriptor`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
