dawidwys commented on a change in pull request #9382: [FLINK-13600][table]
Rework TableEnvironment.connect() class hierarchy
URL: https://github.com/apache/flink/pull/9382#discussion_r311900027
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogTableBuilder.java
##########
@@ -69,73 +61,40 @@
* </code>
*/
@PublicEvolving
-public class CatalogTableBuilder
- extends TableDescriptor
- implements ConnectorFormatDescriptor<CatalogTableBuilder>,
StreamableDescriptor<CatalogTableBuilder> {
+public final class CatalogTableBuilder extends
TableDescriptor<CatalogTableBuilder> {
- private final ConnectorDescriptor connectorDescriptor;
private final TableSchema tableSchema;
- private final boolean isGeneric;
private String comment;
- private Optional<FormatDescriptor> formatDescriptor = Optional.empty();
+ private final boolean isGeneric;
+
private Optional<Statistics> statisticsDescriptor = Optional.empty();
Review comment:
I know this would be unrelated change, but how about we drop the
`statisticsDescriptor` & `metadataDescriptor`. They cannot be set, they are
always empty, so they are effectively useless. Moreover they use `Optional` as
a class field which is against our code style guidelines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
