dawidwys commented on a change in pull request #9382: [FLINK-13600][table]
Rework TableEnvironment.connect() class hierarchy
URL: https://github.com/apache/flink/pull/9382#discussion_r311917540
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/TableDescriptor.java
##########
@@ -19,11 +19,132 @@
package org.apache.flink.table.descriptors;
import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.util.Preconditions;
+
+import javax.annotation.Nullable;
+
+import java.util.Map;
+
+import static
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE;
+import static
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE_VALUE_APPEND;
+import static
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE_VALUE_RETRACT;
+import static
org.apache.flink.table.descriptors.StreamTableDescriptorValidator.UPDATE_MODE_VALUE_UPSERT;
/**
- * Common class for all descriptors describing table sources and sinks.
- */
+ * Describes a table consisting of a connector (in a given update mode) and a
format.
+ */
@PublicEvolving
-public abstract class TableDescriptor extends DescriptorBase {
+public abstract class TableDescriptor<D extends TableDescriptor<D>> extends
DescriptorBase {
Review comment:
Do we need both `TableDescriptor` & `ConnectTableDescriptor`?
There is only a single descriptor that extends from `TableDescriptor`
directly (and to be honest I couldn't find any reasonable usage of it in a
production code).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
