twalthr commented on a change in pull request #9422: [FLINK-13697][table-api]
Removed deprecated ExternalCatalog API
URL: https://github.com/apache/flink/pull/9422#discussion_r315173592
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -180,7 +177,8 @@ public void registerTable(String name, Table table) {
}
CatalogBaseTable tableTable = new
QueryOperationCatalogView(table.getQueryOperation());
- registerTableInternal(name, tableTable);
+ CatalogManagerCommands.createTable(tableTable, false)
+ .executeIn(catalogManager, getTemporaryTablePath(name));
Review comment:
Why can't we integrate `CatalogManagerCommands` into `CatalogManager`? The
first argument of `executeIn` is always the same and basically implements a
member that should be part of the manager itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
