twalthr commented on a change in pull request #9422: [FLINK-13697][table-api]
Removed deprecated ExternalCatalog API
URL: https://github.com/apache/flink/pull/9422#discussion_r315176079
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/sinks/TableSinkUtils.scala
##########
@@ -41,7 +42,7 @@ object TableSinkUtils {
def validateSink(
staticPartitions: JMap[String, String],
query: QueryOperation,
- sinkPath: JList[String],
+ sinkPath: ObjectIdentifier,
Review comment:
nit: update all names to identifier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services