twalthr commented on a change in pull request #9422:  [FLINK-13697][table-api] 
Removed deprecated ExternalCatalog API 
URL: https://github.com/apache/flink/pull/9422#discussion_r315175027
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/QueryOperationConverter.java
 ##########
 @@ -296,7 +297,12 @@ public RelNode visit(SortQueryOperation sort) {
 
                @Override
                public RelNode visit(CatalogQueryOperation catalogTable) {
-                       return 
relBuilder.scan(catalogTable.getTablePath()).build();
+                       ObjectIdentifier tablePath = 
catalogTable.getTablePath();
 
 Review comment:
   Rename `tablePath` to `objectIdentifier` in `CatalogQueryOperation`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to