pnowojski commented on a change in pull request #9383: [FLINK-13248] [runtime]
Adding processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#discussion_r317578748
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
##########
@@ -423,18 +434,25 @@ public boolean hasSelectiveReadingOperator() {
ClassLoader userCodeClassloader,
Map<StreamEdge, RecordWriterOutput<?>> streamOutputs,
List<StreamOperator<?>> allOperators,
- OutputTag<IN> outputTag) {
+ OutputTag<IN> outputTag,
+ IntFunction<MailboxExecutor> mailboxExecutorFactory) {
Review comment:
Instead of `IntFunction<MailboxExecutor>` maybe define a simple
`MailboxFactory` class that has a nicely named method with a named parameter?
As it is now readability heavily depends on the usage, and in the signature of
this constructor it's not obvious what this `IntFunction` should accept.
Actually even usage here is not obvious:
`mailboxExecutorFactory.apply(operatorConfig.getChainIndex());`, since we think
about this parameter as a "priority" and call it that way for the sake of
yielding.
Another issue, is that looking for usages with such interfaces is a bit
problematic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
