pnowojski commented on a change in pull request #9383: [FLINK-13248] [runtime] 
Adding processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#discussion_r317581559
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperator.java
 ##########
 @@ -162,12 +166,20 @@ public void setup(StreamTask<?, ?> containingTask, 
StreamConfig config, Output<S
                }
        }
 
+       void setMailboxExecutor(MailboxExecutor mailboxExecutor) {
+               this.mailboxExecutor = mailboxExecutor;
+       }
+
        @Override
        public void open() throws Exception {
                super.open();
 
                // create the emitter
-               this.emitter = new Emitter<>(checkpointingLock, output, queue, 
this);
+               this.emitter = new Emitter<>(checkpointingLock,
 
 Review comment:
   nit: I think the recent consensus about wrapping the parameters was that the 
first parameter should be also in the new line:
   https://github.com/apache/flink-web/pull/254

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to