pnowojski commented on a change in pull request #9564:
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319480244
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1183,8 +1183,12 @@ public void notifyCheckpointComplete(final long
checkpointID) {
@Override
public void run() {
try {
-
invokable.notifyCheckpointComplete(checkpointID);
- } catch (Throwable t) {
+
invokable.notifyCheckpointCompleteAsync(checkpointID);
Review comment:
if we do not wait, then we will miss the error handling?
But please first respond to my comment about double/nested mailbox/enqueuing
pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
