pnowojski commented on a change in pull request #9564:
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319473779
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1151,7 +1151,10 @@ public void run() {
FileSystemSafetyNet.setSafetyNetCloseableRegistryForThread(safetyNetCloseableRegistry);
try {
-
invokable.triggerCheckpoint(checkpointMetaData, checkpointOptions,
advanceToEndOfEventTime);
+
invokable.triggerCheckpointAsync(checkpointMetaData, checkpointOptions,
advanceToEndOfEventTime);
Review comment:
also hmmm, this is a bit strange pattern. We enqueue some action in a single
threaded `asyncCallDispatcher`, which has mostly only one thing to do: enqueue
something in the mailbox. Can not we simply drop `executeAsyncCallRunnable` and
`asyncCallDispatcher` and go directly to the mailbox?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
